fix: update chrome to 128 firefox to 130 inside Cypress tests in CircleCI #30245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
chore/update_chrome_128_firefox_130
branch
from
7870478 to
6acae41
Compare
AtofStryker
force-pushed
the
chore/update_chrome_128_firefox_130
branch
from
6acae41 to
bcba5ed
Compare
AtofStryker
changed the title
AtofStryker
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/update_chrome_128_firefox_130
|
| Run status |
|
| Run duration | 24m 22s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
1328
|
Skipped
|
0
|
Passing
|
29403
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
44.77%
|
|
|---|---|
|
Untested elements
|
201
|
|
Tested elements
|
167
|
Accessibility
91.29%
|
|
|---|---|
|
Failed rules
|
5 critical
10 serious
2 moderate
2 minor
|
|
Failed elements
|
943
|
jennifer-shehane
previously requested changes
Sep 17, 2024
| @@ -82,7 +82,7 @@ We dynamically generated a new test to display this failure. | |||
|
|
|||
| (Screenshots) | |||
|
|
|||
| - /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x633) | |||
| - /XXX/XXX/XXX/cypress/screenshots/AppCompilationError.cy.jsx/An uncaught error wa (1280x581) | |||
There was a problem hiding this comment.
Are these tests actually testing screenshot behavior? Can we just turn the screenshots off here?
(Not suggesting this optimization be a part of this PR, I could maybe follow up with a PR for this if so)
There was a problem hiding this comment.
I don't think they are. Just looks like the screenshot taken from a given failure
There was a problem hiding this comment.
K, I'll take a look at this.
Co-authored-by: Jennifer Shehane <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
jennifer-shehane
dismissed
their stale review
Dismissing my review comments as addressed
jennifer-shehane
approved these changes
Sep 17, 2024
ryanthemanuel
approved these changes
Sep 17, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
As a prerequisite for doing the WebDriver BiDi work for Firefox, we needed to update to a minimum of Firefox 129 to get mostly complete BiDi support. This knocks out the chrome update as well to be on chrome latest
The main changes were some screenshot height differences, which has been a problem for chrome in the past. We are now seeing it with Firefox as well, though the height for the default parameters is only 1 pixel off. I added some code to mitigate this (a bit hacky, but gets the job done).
There was also a regression introduced with Firefox 129 that incorrectly mutated the checkbox prop on an event if a click event on a checkbox was sent in 129 or up (hence the fix tag)
Steps to test
Test against CI or run the
type_ eventscypress test with/without the fix to reproduce as long as you are on Firefox 129 and above.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?