Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30273
Additional details
We are seeing sporadic failures in
net_stubbing.cy.ts
for the testcan delay and throttle a StaticResponse
caused bydone
getting called multiple times.In looking at the various times this has failed, I noticed that they all had this failure:
I noticed that an earlier test doesn't actually utilize
done
properly, and so my theory is that the callback for one test is being executed in the middle of another test and that is messing a ton of stuff up with respect to the intercepts oncan delay and throttle a StaticResponse
especially since it's retrying it potentially 15 times. The fix on this PR makes sure that we utilizedone
properly. I tested it a bunch in CI and didn't see the error any longer.Steps to test
N/A
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?