Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix net_stubbing flake #30276

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Sep 24, 2024

Fixes: #30273

Additional details

We are seeing sporadic failures in net_stubbing.cy.ts for the test can delay and throttle a StaticResponse caused by done getting called multiple times.

In looking at the various times this has failed, I noticed that they all had this failure:

image

I noticed that an earlier test doesn't actually utilize done properly, and so my theory is that the callback for one test is being executed in the middle of another test and that is messing a ton of stuff up with respect to the intercepts on can delay and throttle a StaticResponse especially since it's retrying it potentially 15 times. The fix on this PR makes sure that we utilize done properly. I tested it a bunch in CI and didn't see the error any longer.

Steps to test

N/A

How has the user experience changed?

N/A

PR Tasks

Copy link

cypress bot commented Sep 24, 2024

cypress    Run #57248

Run Properties:  status check passed Passed #57248  •  git commit 246a0b3bdf: fix flake
Project cypress
Branch Review ryanm/chore/fix-flake-with-static-response
Run status status check passed Passed #57248
Run duration 22m 08s
Commit git commit 246a0b3bdf: fix flake
Committer Ryan Manuel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29395
View all changes introduced in this branch ↗︎
UI Coverage  44.65%
  Untested elements 202  
  Tested elements 167  
Accessibility  91.28%
  Failed rules  5 critical   10 serious   2 moderate   2 minor
  Failed elements 941  

@ryanthemanuel ryanthemanuel merged commit fbe51fc into develop Sep 25, 2024
85 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/chore/fix-flake-with-static-response branch September 25, 2024 14:42
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 25, 2024

Released in 13.15.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.15.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] Failing test causing flake in our driver tests
3 participants