-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DEPLOY.md #5554
Update DEPLOY.md #5554
Conversation
flotwig
commented
Oct 31, 2019
- Document kitchensink release process better
- Clarify pushing up the release commit
- Document kitchensink release process better - Clarify pushing up the release commit
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
DEPLOY.md
Outdated
13. Bump `version` in `package.json` from `develop` branch and then merge into `master`. | ||
14. Using [cypress-io/release-automations][release-automations]: | ||
9. If needed, push out the updated changes to the docs manifest to `on.cypress.io`. | ||
10. If needed, push out an updated [`cypress-example-kitchensink`][cypress-example-kitchensink] on `example.cypress.io` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how fully you want to document this here, but how would you push this out? Is there some script or something that should be run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't know, I think Brian has a script or something, @brian-mann?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see more links in the Deploy doc in general. It's still making some assumptions that you know where all the other parts are.
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Co-Authored-By: Jennifer Shehane <[email protected]>
Co-Authored-By: Jennifer Shehane <[email protected]>
Co-Authored-By: Jennifer Shehane <[email protected]>