feat: minimum version eslint v9 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Support ESLint v9 and above only Support for ESlint v7 & v8 is removed languageOptions ecmaVersion: 2019 and sourceType: module are removed from eslint-plugin-cypress/flat config globals is updated to 15.11.0 eslint-plugin-n is updated to 17.11.1
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
|
jennifer-shehane
approved these changes
Oct 11, 2024
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecmaVersion#215 for flat config onlyIssue
ESLint versions <
v9are no longer supported (see https://eslint.org/version-support/). eslint-plugin-cypress cannot rely on unsupported ESLint versions.Changes
Support for ESLint
v7andv8is removed.Update
peerDependenciesin package.json to"eslint": ">=9"Delete
test-v7from circle.ymlUpdate globals to 15.11.0
Update eslint-plugin-n to 17.11.1
Remove
languageOptionsecmaVersion: 2019andsourceType: modulefrom theeslint-plugin-cypress/flatconfigUninstall explicit
@eslint/eslintrcand@eslint/js(installed automatically as dependency ofeslint)Update documentation
Notes
ci/circleci: test-v7must be removed from branch protection rules. It is no longer used.ci/circleci: test-v8remains.ESLint
v8is still used in circle.yml for thetest:legacyscript, since legacy configurations are still supported by ESLintv9.The v8 RuleTester is however needed for legacy configurations as the v9 RuleTester only tests flat configurations. The blog post eslintrc removed in ESLint v10.0.0 announced plans to remove legacy configurations in ESLint
v10scheduled for end of 2024 or early 2025. At the latest, at this point, eslint-plugin-cypress should follow suit and remove support for legacy configurations.