Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

message: make some strcmps "safe" #5225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

message: make some strcmps "safe" #5225

wants to merge 1 commit into from

Conversation

brong
Copy link
Member

@brong brong commented Jan 20, 2025

This fixes crashers with parsing malformed MESSAGE/RFC822

@lerlacher-fm lerlacher-fm self-requested a review January 20, 2025 23:50
lerlacher-fm
lerlacher-fm approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@lerlacher-fm lerlacher-fm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes might hide some parsing logic errors and should be looked at to see when we might run into the null cases for valid messages. Apart from that it's straightforward and safe.

@brong brong requested a review from ksmurchison January 20, 2025 23:53
@brong
Copy link
Member Author

brong commented Jan 20, 2025

I've added @ksmurchison for review as well before merging it upstream.

ksmurchison
ksmurchison approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we collapse this into one commit?

@brong
Copy link
Member Author

brong commented Jan 21, 2025

LGTM. Can we collapse this into one commit?

sure!

@brong
message: make some strcmps "safe"
3a731bc 
This fixes crashers with parsing malformed MESSAGE/RFC822
@brong brong force-pushed the message-strcmpsafe branch from 8751652 to 3a731bc Compare January 21, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lerlacher-fm lerlacher-fm lerlacher-fm approved these changes

@ksmurchison ksmurchison ksmurchison approved these changes

Assignees
No one assigned
Labels
include-in-fastmail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brong @ksmurchison @lerlacher-fm