Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrus-sasl-2.1.29 release #762

Closed
kloczek opened this issue Apr 20, 2023 · 26 comments
Closed

Cyrus-sasl-2.1.29 release #762

kloczek opened this issue Apr 20, 2023 · 26 comments
Milestone

Comments

@kloczek
Copy link

kloczek commented Apr 20, 2023

cyrus-sasl-2.1.28...master shows +190 commits since last release which was +year ago.
Any plans to release new version? 🤔

@quanah
Copy link
Contributor

quanah commented Apr 20, 2023

master is work on cyrus-sasl 2.2, there is no timeline on that release. We are discussing a 2.1.29 release purely for ensuring openssl 3 compatibility as OpenSSL 1.1.1 series is being retired by the OpenSSL project.

@kloczek
Copy link
Author

kloczek commented Apr 20, 2023

Thank you 👍

@quanah quanah added this to the 2.1.29 milestone Jul 18, 2023
@quanah quanah changed the title New version? Cyrus-sasl-2.1.29 release Jul 18, 2023
quanah added a commit that referenced this issue Jul 18, 2023
For testing, last version updates when it is release time

Signed-off-by: Quanah Gibson-Mount <[email protected]>
@bgermann
Copy link
Contributor

bgermann commented Aug 4, 2023

When will the release happen? All milestone issues are done.

@quanah
Copy link
Contributor

quanah commented Aug 5, 2023

When will the release happen? All milestone issues are done.

DIGEST-MD5 needs removal since there's no way to support it with OpenSSL3.

@bgermann
Copy link
Contributor

bgermann commented Aug 5, 2023

Really? The MD5 implementation in 2.1 is the internal one. RC4 was removed. That leaves us with DES and 3DES. For DES, one has to use the legacy provider but I think you can certainly use 3DES.

@bgermann
Copy link
Contributor

bgermann commented Aug 5, 2023

For a stable version update, mechanism removal is a bit tough for my taste.

@bgermann
Copy link
Contributor

bgermann commented Aug 5, 2023

I see: The des.h functions are deprecated. Would it be an alternative to port to evp.h?

@hyc
Copy link
Contributor

hyc commented Aug 5, 2023

We didn't feel like any porting effort was justified for something we're about to delete. Also DIGEST-MD5 has been "historical" for over 10 years, and any sites using it can just as easily use SCRAM instead.

@bgermann
Copy link
Contributor

bgermann commented Aug 5, 2023

If the OpenSSL installation does not have DES_cbc_encrypt the DIGEST-MD5 will still compile but without any available method. I think this is good enough and it will not break on modern configurations.

In this problem space, e4a9a7e would be a much better backport candidate because srp compilation is broken on OpenSSL without legacy APIs.

@hyc
Copy link
Contributor

hyc commented Aug 6, 2023

Not sure what the point of including it is then, if it has no security layer. Better to just remove it so admins have to recognize that they need to choose a new mech.

@bgermann
Copy link
Contributor

bgermann commented Aug 6, 2023

The point of including is that OpenSSL 3.0 can be configured to retain the legacy APIs and in Debian, it will be like that for the forseeable future. I do not think I am going to upgrade Debian's cyrus-sasl2 to 2.1.29 if DIGEST-MD5 will be dropped. In that case I am going to wait with an update to 2.2 (most likely after the next Debian release trixie). Everyone who wants to get rid of the mechanism can do so by disabling it.

@quanah
Copy link
Contributor

quanah commented Aug 6, 2023

The only purpose for 2.1.29 at this time is for a release that can use OpenSSL 3.0 when there deprecated APIs are not enabled. No distro should be updating to 2.1.29.

@alls0rts
Copy link
Contributor

alls0rts commented Aug 7, 2023

Several distributions have backported the master branch OpenSSL 3 changes to version 2.1.27 and 2.1.28.
Having an official 2.1 branch would be preferable.

@quanah
Copy link
Contributor

quanah commented Aug 7, 2023

Several distributions have backported the master branch OpenSSL 3 changes to version 2.1.27 and 2.1.28. Having an official 2.1 branch would be preferable.

Several distributions took changes from a PR that was not accepted upstream and added them to their builds without consultation with the cyrus-sasl development team.

@alls0rts
Copy link
Contributor

alls0rts commented Aug 7, 2023

Several distributions have backported the master branch OpenSSL 3 changes to version 2.1.27 and 2.1.28. Having an official 2.1 branch would be preferable.

Several distributions took changes from a PR that was not accepted upstream and added them to their builds without consultation with the cyrus-sasl development team.

This thread....

If yes still I think that it would be good to add in 2.1 branch for example openssl 3.x parches and push that as 2.1.29.
quanah commented on May 24, 2022
There are no plans for a new 2.1 release. 2.2.0 is the next planned release series.

@mistotebe
Copy link
Contributor

Please enlighten me, but the only thing I hear being mentioned is the ciphers needed for confidentiality/integrity support (security layers), but all the qop stuff is optional in the RFC.

So if we pull support for qop, I don't see why OpenSSL 3 has any bearing on this and should prevent DIGEST-MD5 from staying in 2.1? Is there anything else?

@hyc
Copy link
Contributor

hyc commented Aug 8, 2023

Those security layers are enabled by default. Most installations using DIGEST-MD5 expect them to be there. Turning them off usually means the mech is ineligible for use (based on configured secprops) and so the mech would effectively disappear/be disabled anyway. What's the point of keeping it then?

@mistotebe
Copy link
Contributor

Except that's the only thing we can't actually deliver any more. Those connections you're talking about would be coming in over plaintext for qop=auth-int or qop=auth-conf to have a point in the first place. qop=auth (the default) is still there and the only secprops that look like they would disable DIGEST-MD5 based on this is minssf.

@hyc
Copy link
Contributor

hyc commented Aug 10, 2023

We (Symas) are having a conference call next week on Monday at 4:30pm GMT to discuss how to proceed. Anyone with an interest in the question can join in using the call-in numbers listed here https://www.symas.com/about-symas to reach extension 76029, no PIN.

@alls0rts
Copy link
Contributor

alls0rts commented Aug 11, 2023

We (Symas) are having a conference call next week on Monday

Thanks @hyc . To be clear and open. On Solaris 11.4 SRU, where
SSL 1.1.1 has already been removed, cyrus-sasl 2.1.28 is currently
being linked with latest SSL 1.0.2. We intend to switch to SSL
3.0 (using patches to 2.1.28) when ready (several other packages
rely on cyrus-sasl and thus need to be switched at the same time).

As such Solaris can skip 2.1.29 (as suggested by @quanah) and look
towards 2.2 in the near future.

@mistotebe
Copy link
Contributor

The outcome of that call has not been noted here. Might be worth giving an outline at least?

ligurio added a commit to tarantool/tarantool that referenced this issue Feb 22, 2024
TODO:

Fix warnings due to using deprecate functions by cyrus-sasl:

```
digestmd5.c:894:5: warning: ‘DES_ede3_cbc_encrypt’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
```

See _cyrusimap/cyrus-sasl#762
ligurio added a commit to tarantool/tarantool that referenced this issue Feb 22, 2024
TODO:

Fix warnings due to using deprecate functions by cyrus-sasl:

```
digestmd5.c:894:5: warning: ‘DES_ede3_cbc_encrypt’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
```

See _cyrusimap/cyrus-sasl#762
Lord-KA pushed a commit to tarantool/tarantool that referenced this issue Apr 25, 2024
TODO:

Fix warnings due to using deprecate functions by cyrus-sasl:

```
digestmd5.c:894:5: warning: ‘DES_ede3_cbc_encrypt’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
```

See _cyrusimap/cyrus-sasl#762
CuriousGeorgiy added a commit to CuriousGeorgiy/tarantool that referenced this issue May 16, 2024
TODO:

Fix warnings due to using deprecate functions by cyrus-sasl:

```
digestmd5.c:894:5: warning: ‘DES_ede3_cbc_encrypt’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
```

See _cyrusimap/cyrus-sasl#762
@mistotebe
Copy link
Contributor

There is still no indication what the outcome of the mentioned call was. From other communication I presume something along the lines that there will be no more releases in the 2.1 stream, instead aiming to release 2.2 at some point.

@kloczek
Copy link
Author

kloczek commented Jul 22, 2024

Why this ticket has been closed if still thee is no new release? 🤔

@quanah
Copy link
Contributor

quanah commented Jul 22, 2024

There will be no new releases of the 2.1 series. This ticket was about 2.1.29, there won't be one.

@Neustradamus
Copy link
Contributor

Dear all,

Latest Cyrus-SASL is 2.1.28 (2022-02-22), soon 3 years.

Can you go here for talk about a new version before Debian 13 freeze soon?

Next Debian 14 will be in 2027:

Thanks in advance.

@mistotebe
Copy link
Contributor

@Neustradamus please stop commenting on every bug report you find, @ mentioning the world etc. It is only going to be seen as spam as countless other projects have told you already and taken together it can be seen as harassment. This is a community project maintained on a volunteer basis, if you want things done (sooner) you have two options: you can step in and help make it happen or you can hire someone to work on whatever you consider a priority.

Right now you are doing neither, on the contrary, your endless stream of comments on random (and mostly closed?) tickets without even engaging in a discussion is taking away from, not contributing to, this project.

Consider this your final warning: if you continue this behaviour, you will be blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants