Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Provides a method to replace baseURL for external unit testing #65

Closed
MangataL opened this issue Jun 16, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@MangataL
Copy link

Is your feature request related to a problem? Please describe.
other packages using the client cannot write a unit test because the baseURL variable cannot be modified and can only access the real tmdb address.

Describe the solution you'd like
add a method to modify baseURL

Describe alternatives you've considered

Additional context

@MangataL MangataL added the enhancement New feature or request label Jun 16, 2024
@cyruzin
Copy link
Owner

cyruzin commented Jun 20, 2024

@MangataL https://github.com/cyruzin/golang-tmdb/releases/tag/v1.6.4

I added two new functions:

SetCustomBaseURL(url string)
GetBaseURL() string

@cyruzin cyruzin closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants