Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all tests has been fixed #54

Merged
merged 2 commits into from
Feb 6, 2024
Merged

all tests has been fixed #54

merged 2 commits into from
Feb 6, 2024

Conversation

cyruzin
Copy link
Owner

@cyruzin cyruzin commented Feb 6, 2024

Description

Fix multiple broken tests..

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Local. But I'm going to hold thid PR until they fix the API: https://www.themoviedb.org/talk/65b3e54e5541fa0164b18674?language=pt-BR#65c293a0e7c097017dcf0950. Because of this error, 2 tests are failing.

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cyruzin cyruzin self-assigned this Feb 6, 2024
@cyruzin cyruzin added bug Something isn't working enhancement New feature or request labels Feb 6, 2024
Copy link
Owner Author

@cyruzin cyruzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests has been fixed. They fix the API.

@cyruzin cyruzin merged commit bde7a62 into master Feb 6, 2024
4 checks passed
@cyruzin cyruzin deleted the bugfix/broken_test_fix branch February 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant