Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the condition for mask export. #327

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Fix the condition for mask export. #327

merged 1 commit into from
Aug 24, 2022

Conversation

Arkkienkeli
Copy link
Member

This branch solves #326, when export did not work properly without masks.
The current behaviour is the following:
if outlines field and mask_objects:true are both in the config - then the cells are exported with masks
if no outlines field and mask_objects:false in the config - the cells are exported without masks correctly
if no outlines field and mask_objects:true in the config - DeepProfiler will crash.

I was wondering if we want the following functionality later: export masked cells right away without saving the mask itself.

@Arkkienkeli Arkkienkeli requested a review from jccaicedo June 24, 2022 17:38
@vasudev-sharma
Copy link

Hi @Arkkienkeli, thanks for this PR which aims to resolve the issue #326. Although this PR hasn't been merged into the master branch, I was wondering can I use this branch to resolve the issue I was facing earlier?

@Arkkienkeli
Copy link
Member Author

Hi @vasudev-sharma sorry for not coming back to that,
yes it did work and I guess I am going to merge it for now as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants