Box selection panning after some time

[jhonatandarosa]

When using box selection, the graph starts to pan after some time.

Steps to reproduce:

• Access: http://jsbin.com/sahewozena/1/edit?js,output
• Add property boxSelectionEnabled: true
• Make a box selection and don't release the mouse button
• wait about 2 seconds
• move the mouse
  The graph starts to pan

[rockshandy]

I was just about to log this same issue actually.

[maxkfranz]

Odd. I didn't see that on my local instance before publishing, but there were some issues with publishing the last x.y.z release. I'll take a look; thanks

[maxkfranz]

Adding to 2.3.8 milestone. Given the severity of the issue, it may even merit its own release.

[danieljue]

Thank you Max, we would really like to use this latest version of 2.3.7+, and this bug came up for us as well.

[maxkfranz]

Thanks for the feedback; I hope to fix this tomorrow. If you all could try it out too once I push it but before I formally release it, that would be a big help. Thanks

[bertomaniac]

I'm using 2.3.4 and just tried this out in our environment and wasn't able to reproduce. Perhaps this bug was introduced in 2.3.5+?

[maxkfranz]

Thank you for your patience, guys. I've pushed a fix. Please try it out and I'll push out the release ASAP.

Snapshot build: http://js.cytoscape.org/download/cytoscape.js-snapshot-16cf86597e-1420740052765.zip

[jhonatandarosa]

Hi Max, thanks for your immediate attention on this issue.
I tested the snapshot in our application and on a simple demo from the site.

The issue with the box selection seems to be solved, but the pan stopped working.
Tried with both values in boxSelectionEnabled.
Also checked if the pan was enabled with userPanningEnabled() and panningEnabled(), both returned true

[maxkfranz]

OK. That's actually a bit of a relief in a way, because I re-enabled a "magic" number condition in that build. I'll take a look; thanks

[maxkfranz]

Maybe this?

Snapshot: http://js.cytoscape.org/download/cytoscape.js-snapshot-4294a1643f-1420754382449.zip

[jhonatandarosa]

Yep, this snapshot works perfectly. Thanks

[rockshandy]

This fixes my issue too. There is sometimes a slight delay between when the shaded circle appears to indicate I clicked long enough to start panning, and switching to panning mode. Box selection starts instead sometimes if I move my mouse right after the panning indicator appears. Waiting a little longer after I click works as expected, and panning happens instead. This doesn't happen very often, but I wanted to mention it incase someone else observed this.

[maxkfranz]

Ref: 4327f51

Snapshot: http://js.cytoscape.org/download/cytoscape.js-snapshot-4327f51c72-1420824418477.zip

[maxkfranz]

Previous update fixed the fast case that shows both UI indicators. There is also the slow case, which is harder to time (i.e. must be precise at a later time).

[rockshandy]

Seems to fix the issue I mentioned, thanks for the fix and quick turn around!

[maxkfranz]

OK. There's still a minor graphical glitch if the timing is slow but very precise. Closing for 2.3.8 release.

Ref: #800