Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cytoscape Leaking DOM? #793

Closed
i2shar opened this issue Jan 10, 2015 · 1 comment
Closed

Cytoscape Leaking DOM? #793

i2shar opened this issue Jan 10, 2015 · 1 comment

Comments

@i2shar
Copy link

i2shar commented Jan 10, 2015

Each time a cytoscape instance is created and destroyed, there are remnant DOM nodes added to the body that are not removed. They seem to correspond to the last node in the graph, "George" in this case.

image

Here's the plunker: http://run.plnkr.co/plunks/4vKxA6Lqlqm7DxiuE8At/ and code is at http://plnkr.co/edit/4vKxA6Lqlqm7DxiuE8At?p=info

@markov00
Copy link
Contributor

Hi, I think I've found the problem and I've issued a PR. The div is used to calculate the dimension of each labels, but it's appended to the body and never removed during the destroy.
I've proposed two way to solve it: removing the element during the destroy or appending the element into the cytoscape container. Either methods works correctly.

maxkfranz added a commit that referenced this issue Jan 20, 2015
fix #793 leaked labelCalcDiv used to calculate label dimensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants