add optional wasm feature with web-time dependency #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no need for the optional feature, since
|
cyypherus
requested changes
Jan 28, 2025
This is based on the fact that web-time only exports std::time if it is not on wasm.
|
@hecrj thanks for pointing that out. I was not aware of that. |
hecrj
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional wasm feature. This feature is optional. If it is active the implementation of
AnimationTimeis switched from std::time::Instant to web-time::Instant.As background. This PR is supposed to fix an issue in the iced dev branch which utilities lilt and can not compile to wasm as of now.