fix: detect methods

d0whc3r · Oct 8, 2019 · 04a7106 · 04a7106
1 parent 02f3b82
commit 04a7106
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/rules/own-methods-must-be-private.ts b/src/rules/own-methods-must-be-private.ts
@@ -27,7 +27,7 @@ const rule: Rule.RuleModule = {
         const originalNode = parserServices.esTreeNodeToTSNodeMap.get(node);
         const stencilDecorator = originalNode.decorators && originalNode.decorators.some(
             (dec: any) => DECORATORS.includes(dec.expression.expression.escapedText));
-        const stencilCycle = LIFECYCLE_METHODS.includes(originalNode.name.escapedText);
+        const stencilCycle = LIFECYCLE_METHODS.includes(originalNode.name && originalNode.name.escapedText);
         if (!stencilDecorator && !stencilCycle && !isPrivate(originalNode)) {
           const text = String(originalNode.getFullText());
           context.report({

diff --git a/src/rules/required-prefix.ts b/src/rules/required-prefix.ts
@@ -29,6 +29,10 @@ const rule: Rule.RuleModule = {
           return;
         }
         const [{ tag }] = parseDecorator(component);
+        if (!tag) {
+          console.warn('[required-prefix] No tag detected for component');
+          return;
+        }
         const options = context.options[0];
         const match = options.some((t: string) => tag.startsWith(t));