Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

[DCOS-51454] Remove irrelevant Mesos REPL test #75

Closed
wants to merge 1 commit into from

Conversation

farhan5900
Copy link

@farhan5900 farhan5900 commented Oct 17, 2020

Reference PR#54

What changes were proposed in this pull request?

removed not working test which started failing when MESOS_NATIVE_JAVA_LIBRARY environment variable is set. Justification:

  • current cluster url localquiet will never pass a regexp check when SparkContext is created
  • if change cluster url to local then there's no point in checking for Mesos integration specifically
  • the presence of MESOS_NATIVE_JAVA_LIBRARY environment variable doesn't mean that Mesos is available while Mesos native lib is used for building Mesos Cluster Scheduler
  • this is an integration test which assumes Mesos cluster availability and doesn't play well with the rest of the tests (there's no YARN or K8s tests)

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Added Unit Test

@farhan5900
Copy link
Author

This PR is just for reference, so final and effective change has been moved to #69.

@farhan5900 farhan5900 closed this Oct 20, 2020
@farhan5900 farhan5900 deleted the repl-test-fix branch October 20, 2020 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant