fix crash on missing top bin #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns-in-d3v7-4-1-update unit test: d3.bin().domain([4, 5])([5]) the issue is that we have removed the last bin, but then want to assign the largest value to it because floor(x1) === x1 I'm not sure if the fix catches all cases…
mbostock
reviewed
Apr 7, 2022
|
hmmm this is only fixing one of the two original cases… adding a test 🤔 |
|
I don't understand why the test fails with 17 eights, but not with 16 eights! |
mbostock
reviewed
Apr 7, 2022
mbostock
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d3.bin().domain([4, 5])([5])crashesthe issue is that we have removed the last bin, but then want to assign the largest value to it because floor(x1) === x1
I'm not sure if the fix catches all cases…
issue reported by weiglemc at https://observablehq.com/@weiglemc/demonstrating-issue-with-d3-bins-in-d3v7-4-1-update