fractional bandwidth, using d3.blur #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
approved these changes
Jul 3, 2022
There was a problem hiding this comment.
I think we should consider this a breaking change for the purposes of this library (since anyone loading d3-array@2 will break as d3.blur2 will be undefined). However, it is not a breaking change for d3 and for Plot since the only breaking change is the stricter dependency requirement, and that caveat only applies if you’re not reading the dependencies from package.json as when using vanilla script tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on d3/d3-array#151
Note that the blur radius is defined as
r * pow2k * 0.95: the 0.95 factor is here to be as faithful as possible to the current version. We should probably accept that this is a change and set this factor to 1 for consistency with d3-array.demo https://observablehq.com/@d3/fractional-bw-density-60
closes #59