Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit end event after last zoom which had an effect #179

Closed
wants to merge 1 commit into from
Closed

Emit end event after last zoom which had an effect #179

wants to merge 1 commit into from

Conversation

Herst
Copy link
Contributor

@Herst Herst commented Jul 24, 2019

See #158

@Herst
Copy link
Contributor Author

Herst commented Jul 30, 2019

@mbostock That ought do it and not break anything, right? Because the stored mouse location plays no role in those cases where the wheel event wouldn't make any difference (e.g. because of the scaleExtent).

@mbostock
Copy link
Member

This looks correct to me. The new else is redundant (because of the preceding return).

@Herst
Copy link
Contributor Author

Herst commented Jul 31, 2019

Fixed.

@mbostock
Copy link
Member

mbostock commented Aug 5, 2019

Merged as f4c6c79.

@mbostock mbostock closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Herst @mbostock