Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added standard script for TikTok #27

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Added standard script for TikTok #27

merged 3 commits into from
Nov 8, 2024

Conversation

trbKnl
Copy link
Collaborator

@trbKnl trbKnl commented Nov 8, 2024

content of the PR

  • fixed bug in props, it was correct previously, even the doc string was correct, but the class changed. I think at some point I probably brainfarted and introduced the bug. It should be a typed dict, else the linter will go crazy.
  • I commented the footer out, its not needed anymore, the footer was there so participants would be able to skip in the flow. This is not needed (and unwanted) anymore. Because Next now tracks progress of participants, and it counts the number of completes (if participants reached exit in the script)
  • Added tiktok, with the optimization see browsing_history_to_df

Copy link
Collaborator

@paulmaxus paulmaxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@trbKnl trbKnl merged commit b22abf8 into master Nov 8, 2024
1 check passed
@trbKnl trbKnl deleted the tiktok-standard-script branch November 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants