Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS! #49

Merged
merged 55 commits into from
Aug 27, 2024
Merged

Add ROS! #49

merged 55 commits into from
Aug 27, 2024

Conversation

da-luce
Copy link
Owner

@da-luce da-luce commented Aug 16, 2024

Begin using ROS as the basis for our project.

Base automatically changed from ci to main August 17, 2024 19:42
@da-luce da-luce requested a review from AriMirsky August 17, 2024 19:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.16129% with 23 lines in your changes missing coverage. Please review.

Files Patch % Lines
src/waypoints/waypoints/waypoint_generator.py 77.66% 23 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/waypoints/tests/test_waypoint_generator.py 100.00% <100.00%> (ø)
src/waypoints/waypoints/waypoint_generator.py 77.66% <77.66%> (ø)

... and 13 files with indirect coverage changes

Copy link
Collaborator

@AriMirsky AriMirsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also wondering what's your plan with the development process for the unrosified folder? Besides that, just fixing the gitignore is the only reason I didn't approve this pr

.gitignore Outdated
@@ -1,13 +1,32 @@
# Cache files
__pycache__/
*cache*
<<<<<<< HEAD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an unresolved merge conflict?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, will take care of that


[tool.black]
line-length = 88
target-version = ["py39"]
skip-string-normalization = true

[tool.pylint]
disable = ["W0511", "C0301"]
disable = ["W0511", "C0301", "E1101", "E0237"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why are we disabling these rules?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way ROS requires us to setup the code base results in a few linting errors within Python. It's rather annoying and couldn't find a reasonable solution so this is like a short-term solution to get linting to pass.

@da-luce
Copy link
Owner Author

da-luce commented Aug 20, 2024

@AriMirsky I was planning on using whatever we can from unrosified to ROS nodes as we find fit. Nothing really specific, just to reuse and refactor as necessary.

@da-luce da-luce requested a review from AriMirsky August 21, 2024 01:21
@da-luce da-luce merged commit 5b6218e into main Aug 27, 2024
1 check passed
@da-luce da-luce deleted the ros branch August 27, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants