-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROS! #49
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also wondering what's your plan with the development process for the unrosified folder? Besides that, just fixing the gitignore is the only reason I didn't approve this pr
.gitignore
Outdated
@@ -1,13 +1,32 @@ | |||
# Cache files | |||
__pycache__/ | |||
*cache* | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an unresolved merge conflict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, will take care of that
|
||
[tool.black] | ||
line-length = 88 | ||
target-version = ["py39"] | ||
skip-string-normalization = true | ||
|
||
[tool.pylint] | ||
disable = ["W0511", "C0301"] | ||
disable = ["W0511", "C0301", "E1101", "E0237"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, why are we disabling these rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way ROS requires us to setup the code base results in a few linting errors within Python. It's rather annoying and couldn't find a reasonable solution so this is like a short-term solution to get linting to pass.
@AriMirsky I was planning on using whatever we can from unrosified to ROS nodes as we find fit. Nothing really specific, just to reuse and refactor as necessary. |
Begin using ROS as the basis for our project.