Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtitle position #103

Merged
merged 5 commits into from
Mar 29, 2018
Merged

Conversation

crew102
Copy link
Contributor

@crew102 crew102 commented Mar 21, 2018

Pretty self-explanatory. Should close #99.

@daattali
Copy link
Owner

had to do some merges manually because of previous PR, but looks good. If it passes the travis checks, I'll merge to master and prepare for CRAN submission

@daattali
Copy link
Owner

Hmm it looks like that merge that I tried to do within the github web interface screwed something up, because tests are now failing. Were tests passing before for this PR? Do you mind submitting the PR again, I'm sorry for the extra trouble

@crew102
Copy link
Contributor Author

crew102 commented Mar 29, 2018

Yep, I will fix and resubmit later today

@crew102
Copy link
Contributor Author

crew102 commented Mar 29, 2018

should be all set

@daattali daattali merged commit 73eedfe into daattali:master Mar 29, 2018
@crew102 crew102 deleted the fix-subtitle-position branch June 14, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtitle position changes based on presence or absence of title
2 participants