Same road mode #46
Open
Same road mode #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also closes #45 |
dabreegster
requested changes
Dec 25, 2023
|
My bad, i'll try to fix the problems asap |
bez.tytuluf8.mp4this should work now |
dabreegster
reviewed
Jan 12, 2024
| @@ -174,6 +174,8 @@ | |||
| }); | |||
| let idCounter = 0; | |||
| let snapTool = document.getElementById("snap-tool"); | |||
| let lastRouteName = null; | |||
| @@ -384,6 +402,9 @@ export class RouteSnapper { | |||
| #redraw() { | |||
| if (this.loaded) { | |||
| let gj = JSON.parse(this.inner.renderGeojson()); | |||
| if (gj.length == 0) { | |||
There was a problem hiding this comment.
Fairly sure this is a bug. We might have been drawing something previously, then the user makes a change like deleting a waypoint, and there's no longer anything valid to draw. In that case, we still want to update MapLibre and stop drawing things.
| }; | ||
|
|
||
| if !is_connected(node1, current, &self.router) { | ||
| return String::from("[]"); |
There was a problem hiding this comment.
In this case maybe we don't want to draw the current extension to the route (this big if block), but we still want to draw any confirmed waypoints and parts of the route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #44
Performance-wise, I don't really see a difference. All tested.