fix: Support odd characters in pathnames for Go (#4257)

Fixes #4120 <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
dafny-lang · Jul 24, 2023 · 54ccbb8 · 54ccbb8
1 parent 3b876aa
commit 54ccbb8
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 13 deletions.
diff --git a/Source/DafnyCore/Compilers/GoLang/Compiler-go.cs b/Source/DafnyCore/Compilers/GoLang/Compiler-go.cs
@@ -56,7 +56,7 @@ private struct Import {
     protected override void EmitHeader(Program program, ConcreteSyntaxTree wr) {
       wr.WriteLine("// Dafny program {0} compiled into Go", program.Name);
 
-      ModuleName = MainModuleName = program.MainMethod != null ? "main" : Path.GetFileNameWithoutExtension(program.Name);
+      ModuleName = MainModuleName = program.MainMethod != null ? "main" : TransformToClassName(Path.GetFileNameWithoutExtension(program.Name));
 
       wr.WriteLine("package {0}", ModuleName);
       wr.WriteLine();
@@ -109,6 +109,9 @@ void EmitImports(ConcreteSyntaxTree wr, out ConcreteSyntaxTree importWriter, out
       }
     }
 
+    public static string TransformToClassName(string baseName) =>
+      Regex.Replace(baseName, "[^_A-Za-z0-9$]", "_");
+
     public override void EmitCallToMain(Method mainMethod, string baseName, ConcreteSyntaxTree wr) {
       var companion = TypeName_Companion(UserDefinedType.FromTopLevelDeclWithAllBooleanTypeParameters(mainMethod.EnclosingClass), wr, mainMethod.tok, mainMethod);
 

diff --git a/Test/dafny4/git-issue105.dfy.go.check b/Test/dafny4/git-issue105.dfy.go.check
diff --git a/Test/dafny4/git-issue43.dfy.go.check b/Test/dafny4/git-issue43.dfy.go.check
diff --git a/Test/dafny4/git-issue79.dfy.go.check b/Test/dafny4/git-issue79.dfy.go.check
diff --git a/Test/git-issues/git-issue-2441.dfy.go.check b/Test/git-issues/git-issue-2441.dfy.go.check
diff --git a/Test/git-issues/github-issue-3343.dfy.go.check b/Test/git-issues/github-issue-3343.dfy.go.check
diff --git a/docs/dev/news/4257.fix b/docs/dev/news/4257.fix
@@ -0,0 +1 @@
+Support odd characters in pathnames for Go