fix: Exclude ghost variables from free-var substitution #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
Oct 10, 2022
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| - fix: Compiled lambdas now close only on non-ghost variables (https://github.com/dafny-lang/dafny/pull/2854) | |||
| - fix: Crash in the LSP in some code that does not parse (https://github.com/dafny-lang/dafny/pull/2833) | |||
| - fix: Exclude ghost variables from compilation of lambda-expression closures (https://github.com/dafny-lang/dafny/pull/2873) | |||
There was a problem hiding this comment.
I think your fix is the same as the fix of the PR I merged 5 days ago 😁
#2854
There was a problem hiding this comment.
Oh, by golly, you're right.
|
Looks like we had a race condition, my PR was merged 5 days ago. See if it fixes exactly your problem: |
jtristan
approved these changes
Oct 11, 2022
|
Fixed by #2854. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes ghost variables from the closures that are generated by compiler (for all targets).
Fixes #2872
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.