Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reference the correct this after removing the tail call of a function or method #5474

Merged
merged 8 commits into from
May 24, 2024

Conversation

fabiomadge
Copy link
Collaborator

Fixes #4684

Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Fixing the Rust test is should be a high priority, though. I'll make sure @MikaelMayer knows about it.

@fabiomadge fabiomadge enabled auto-merge (squash) May 24, 2024 20:53
@fabiomadge fabiomadge merged commit 2d397f9 into dafny-lang:master May 24, 2024
21 checks passed
@MikaelMayer
Copy link
Member

FIxing the rust test is definitely necessary, thanks for notifying.
However, it's not a high priority as there are plenty of other tests that we need to fix first. If it was a high priority, I would have requested that this PR to not be merged on the first place as it would have broken one of our compilers.

@fabiomadge fabiomadge deleted the fix_4684 branch May 27, 2024 10:47
atomb added a commit to atomb/dafny that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"this" not protected in lambdas in tail-recursive functions
3 participants