Add iOS support and let parent handle disposal of search box #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamshafil this's pretty awesome, can you share a screen recording? |
|
Apologize for the late response. I have attached the screen recording below. As you can see there is no bug when scrolling down or refreshing. Simulator.Screen.Recording.-.iPhone.16.Plus.-.2024-12-18.at.22.13.02.mp4 |
|
@alamshafil beautiful improvement. This's wonderful, great job! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for iOS (Xcode project file and Pod file).
Additionally, a bug in the iOS build is fixed. The code now ensures proper disposal of
searchTermControllerinhome_page.dartand removed unnecessary disposal insearch_box.dart.(This would cause a race-condition between the search box disposing itself since it out of the list view of the parent when scrolling down, but parent does not want to dispose to keep it in the list view.)