[pyright] Add --skip-typecheck option #20445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @smackesey and the rest of your teammates on |
smackesey
force-pushed
the
sean/pyright-skip-typecheck
branch
from
6cd4f45 to
bab6b03
Compare
[INTERNAL_BRANCH=sean/pyright-skip-typecheck]
smackesey
force-pushed
the
sean/pyright-skip-typecheck
branch
from
bab6b03 to
1f75c11
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Internal companion PR: dagster-io/internal#8681 Add `--skip-typecheck` option to `run-pyright-py` script and have `make rebuild_pyright_pins` use it. This allows us to run `make rebuild_pyright_pins` in CI to ensure env can be built from requirements without caring about typecheck results. ## How I Tested These Changes Ran `make rebuild_pyright_pins` locally, confirmed skip of typecheck (results not included here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Internal companion PR: https://github.com/dagster-io/internal/pull/8681
Add
--skip-typecheckoption torun-pyright-pyscript and havemake rebuild_pyright_pinsuse it. This allows us to runmake rebuild_pyright_pinsin CI to ensure env can be built from requirements without caring about typecheck results.How I Tested These Changes
Ran
make rebuild_pyright_pinslocally, confirmed skip of typecheck (results not included here).