[buildkite] stop using str Enum #25874
Merged
+36
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on |
alangenfeld
force-pushed
the
al/11-12-_buildkite_stop_using_str_enum
branch
4 times, most recently
from
085780d to
ef58734
Compare
alangenfeld
force-pushed
the
al/11-12-_buildkite_stop_using_str_enum
branch
from
ef58734 to
f7cb0a6
Compare
gibsondan
approved these changes
Nov 12, 2024
Comment on lines
+67
to
73
| def backcompat_extra_cmds(_, factor: Optional[str]) -> List[str]: | ||
| tox_factor_map = { | ||
| "user-code-latest-release": LATEST_DAGSTER_RELEASE, | ||
| "user-code-earliest-release": EARLIEST_TESTED_RELEASE, | ||
| } | ||
|
|
||
| assert factor | ||
| webserver_version = DAGSTER_CURRENT_BRANCH |
There was a problem hiding this comment.
aligning the typing [1] makes factor Optional but we must always be getting it in this context so i just asserted to make the type checker happy
alangenfeld
commented
Nov 12, 2024
Comment on lines
+67
to
73
| def backcompat_extra_cmds(_, factor: Optional[str]) -> List[str]: | ||
| tox_factor_map = { | ||
| "user-code-latest-release": LATEST_DAGSTER_RELEASE, | ||
| "user-code-earliest-release": EARLIEST_TESTED_RELEASE, | ||
| } | ||
|
|
||
| assert factor | ||
| webserver_version = DAGSTER_CURRENT_BRANCH |
There was a problem hiding this comment.
aligning the typing [1] makes factor Optional but we must always be getting it in this context so i just asserted to make the type checker happy
| @@ -201,7 +205,7 @@ def build_k8s_suite_steps(): | |||
| def build_integration_suite_steps( | |||
| directory: str, | |||
| pytest_tox_factors: Optional[List[str]], | |||
| pytest_extra_cmds: Optional[Callable] = None, | |||
| pytest_extra_cmds: Optional[PytestExtraCommandsFunction] = None, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to enable building the pipeline in newer python versions as well as the current version
python/cpython#100458
How I Tested These Changes
bk