Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-dbt] Refactor UnitTestDefinition instantiation in utils.py to use from_dict method #27052

Merged
merged 2 commits into from
Feb 5, 2025
Merged

[dagster-dbt] Refactor UnitTestDefinition instantiation in utils.py to use from_dict method #27052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1559c25
[dagster-dbt] Refactor UnitTestDefinition instantiation in utils.py t…
kang8 Jan 13, 2025
9452c84
[dagster-dbt] Let dbt19 also be added to the test
kang8 Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/dagster-buildkite/dagster_buildkite/steps/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ def tox_factors_for_folder(tests_folder_name: str) -> List[str]:
"python_modules/libraries/dagster-dbt",
pytest_tox_factors=[
f"{deps_factor}-{command_factor}"
for deps_factor in ["dbt17", "dbt18"]
for deps_factor in ["dbt17", "dbt18", "dbt19"]
for command_factor in ["cloud", "core-main", "core-derived-metadata"]
],
),
Expand Down
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-dbt/dagster_dbt/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def __getattr__(self, item):
{
"unit_tests": {
# unit test nodes must be of type UnitTestDefinition
unique_id: UnitTestDefinition(**info)
unique_id: UnitTestDefinition.from_dict(info)
for unique_id, info in manifest_json["unit_tests"].items()
},
}
Expand Down
4 changes: 4 additions & 0 deletions python_modules/libraries/dagster-dbt/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ deps =
dbt18: dbt-duckdb==1.8.*
dbt18: dbt-snowflake==1.8.*
dbt18: dbt-bigquery==1.8.*
dbt19: dbt-core==1.9.*
dbt19: dbt-duckdb==1.9.*
dbt19: dbt-snowflake==1.9.*
dbt19: dbt-bigquery==1.9.*
-e .[test]
allowlist_externals =
/bin/bash
Expand Down