Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#854] config: fix: BasePath config is not working #860

Merged
merged 26 commits into from
Feb 24, 2025
Merged

Conversation

yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented Feb 23, 2025

Issue: #854

@yottahmd yottahmd marked this pull request as ready for review February 24, 2025 08:41
@yottahmd yottahmd merged commit be37a0b into main Feb 24, 2025
4 checks passed
@yottahmd yottahmd deleted the 854-base-path branch February 24, 2025 16:29
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 156 lines in your changes missing coverage. Please review.

Project coverage is 56.05%. Comparing base (7bbb13d) to head (a70d706).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/context.go 74.45% 42 Missing and 17 partials ⚠️
internal/cmd/startall.go 52.72% 21 Missing and 5 partials ⚠️
internal/config/loader.go 91.41% 7 Missing and 7 partials ⚠️
internal/cmd/stop.go 64.70% 9 Missing and 3 partials ⚠️
cmd/main.go 0.00% 11 Missing ⚠️
internal/config/config.go 62.06% 6 Missing and 5 partials ⚠️
internal/cmd/scheduler.go 65.51% 7 Missing and 3 partials ⚠️
internal/cmd/server.go 73.91% 4 Missing and 2 partials ⚠️
internal/cmd/restart.go 93.33% 1 Missing and 1 partial ⚠️
internal/cmd/retry.go 92.30% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   55.66%   56.05%   +0.39%     
==========================================
  Files          75       75              
  Lines        8174     8188      +14     
==========================================
+ Hits         4550     4590      +40     
+ Misses       3225     3213      -12     
+ Partials      399      385      -14     
Files with missing lines Coverage Δ
internal/cmd/dry.go 72.36% <100.00%> (ø)
internal/cmd/flags.go 100.00% <100.00%> (ø)
internal/cmd/status.go 62.50% <100.00%> (ø)
internal/config/resolver.go 100.00% <100.00%> (ø)
internal/scheduler/scheduler.go 68.75% <100.00%> (ø)
internal/cmd/start.go 66.66% <96.55%> (ø)
internal/cmd/restart.go 56.93% <93.33%> (ø)
internal/cmd/retry.go 56.73% <92.30%> (ø)
internal/cmd/version.go 0.00% <0.00%> (ø)
internal/cmd/server.go 73.91% <73.91%> (ø)
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bbb13d...a70d706. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant