Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#785] persistence: feat: support concurrent execution of the same DAG #868

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

yottahmd
Copy link
Collaborator

Issue: #785

@yottahmd yottahmd force-pushed the 786-refactor-persistence branch from dbff7dd to 1d0b644 Compare February 28, 2025 11:57
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 59.31255% with 509 lines in your changes missing coverage. Please review.

Project coverage is 56.52%. Comparing base (6afd63c) to head (b30a4aa).

Files with missing lines Patch % Lines
internal/persistence/jsondb/jsondb.go 60.55% 88 Missing and 26 partials ⚠️
internal/persistence/jsondb/record.go 61.18% 69 Missing and 23 partials ⚠️
internal/digraph/exec.go 28.57% 55 Missing ⚠️
internal/agent/agent.go 44.15% 38 Missing and 5 partials ⚠️
internal/persistence/jsondb/writer.go 50.60% 29 Missing and 12 partials ⚠️
internal/digraph/scheduler/scheduler.go 76.97% 35 Missing ⚠️
internal/client/client.go 60.46% 15 Missing and 2 partials ⚠️
internal/digraph/dag.go 25.00% 14 Missing and 1 partial ⚠️
internal/scheduler/scheduler.go 45.45% 12 Missing ⚠️
internal/digraph/condition.go 35.29% 9 Missing and 2 partials ⚠️
... and 13 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   55.98%   56.52%   +0.53%     
==========================================
  Files          75       76       +1     
  Lines        8195     8731     +536     
==========================================
+ Hits         4588     4935     +347     
- Misses       3220     3378     +158     
- Partials      387      418      +31     
Files with missing lines Coverage Δ
internal/client/interface.go 100.00% <ø> (ø)
internal/cmd/context.go 75.31% <100.00%> (+1.70%) ⬆️
internal/cmd/status.go 62.50% <100.00%> (ø)
internal/config/loader.go 88.00% <100.00%> (+0.03%) ⬆️
internal/digraph/executor/mail.go 32.75% <100.00%> (ø)
internal/digraph/executor/ssh.go 35.13% <100.00%> (-0.58%) ⬇️
internal/digraph/loader.go 63.80% <100.00%> (-0.66%) ⬇️
internal/digraph/template.go 28.00% <ø> (ø)
internal/logger/context.go 82.85% <100.00%> (+17.14%) ⬆️
internal/persistence/node.go 24.56% <ø> (ø)
... and 24 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afd63c...b30a4aa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant