Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower System.ValueTuple version dependency. #280

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

NN---
Copy link
Contributor

@NN--- NN--- commented Feb 27, 2022

No description provided.

@dahall
Copy link
Owner

dahall commented Feb 27, 2022

Is the intent to reduce overall dependencies?

@NN---
Copy link
Contributor Author

NN--- commented Feb 27, 2022

The intent to use lower version of dependency to prevent the following conflict.
Also it turns out that there are redundant dependencies and having in one place is enough.

theraot/Theraot#182

@dahall
Copy link
Owner

dahall commented Feb 28, 2022

@NN--- With the committed but unreleased changes made to remove older .NET dependencies, the dependency on Threraot is removed. Is this PR still needed?

@NN---
Copy link
Contributor Author

NN--- commented Feb 28, 2022

Yes.
It is better to have lower version in any case if possible.

@dahall dahall merged commit 95328a6 into dahall:master Feb 28, 2022
@NN--- NN--- deleted the fix/valuetuple branch February 28, 2022 18:55
@NN---
Copy link
Contributor Author

NN--- commented Feb 28, 2022

Thank you!

OwnageIsMagic referenced this pull request Mar 1, 2022
…nd 3.0 since all are or shortly will be out of support. Added support for .NET 4.6.2 and 4.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants