Simplify/fix join-path. #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #268 and add some initial Pester tests.
dahlbyk
reviewed
Dec 29, 2016
| Get-SshPath | Should BeExactly $Home\.ssh\id_rsa | ||
| } | ||
| It 'Returns the correct path given a filename' { | ||
| Get-SshPath mykey | Should BeExactly $Home\.ssh\mykey |
There was a problem hiding this comment.
Note that these path expectations will likely fail on not-Windows.
There was a problem hiding this comment.
It shouldn't but I will test it. PowerShell itself handles both \ and / as path sep chars. Issues arise though when a path is passed down to a native application.
There was a problem hiding this comment.
OK so PowerShell internally handles both just fine but when you "compare exactly", the expected has to be correct. Submitting a PR to fix this.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #268 and add some initial Pester tests.