Allow specifying a Picasso instance to use when loading images #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods to allow configuring the Picasso instance used by the slider when it loads images.
|
👍 |
daimajia
added a commit
that referenced
this pull request
May 14, 2015
Allow specifying a Picasso instance to use when loading images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my application I'm already using Picasso and OkHttp to perform various image loading and HTTP requests. OkHttp and Picasso are able to share a common HTTP cache if the Picasso instance is configured correctly.
This change allows the user to supply a Picasso instance for AndroidImageSlider library to use. With this change I can turn on Picasso's debug indicators and I can see that the slider widget is using the same cache that the rest of my application is using.