-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed the PageChangeListener in the PageIndicator #98
Conversation
Actually there is a better solution on #42. Cause let user involk PagerIndicator.setOnPageChangeListener will make them not easy to understand what they are doing. I think we can overide |
Sounds like a good idea. Thanks for looking into this. |
Any interesting to be a collaborator of this project? |
I just recently switched to Android Studio and Gradle and I've never worked on a stand-alone library like this so I probably wouldn't be much help, but thanks for asking. |
@massimobio Great! Feel free to contact me when you are ready! |
Could you point me to some documents or tutorials specifically for working with these kinds of libraries? I wasn't even able to get the demo app to compile correctly. I had to manually pull out the classes and drop them into my project. Gradle is great for using open source projects, but I'm still at a loss about how things work behind then scenes. I'm eager to learn so I can contribute. |
You can check this video to learn how to import GitHub project into Android Studio. Check this to learn how to make custom view.
Check this to learn how to working with GitHub collaborators (Git workflow): :-D Any problem or question feel free to comment here. |
Wonderful. Thank you very much. |
Hi, I added an ArrayList of listeners in the ViewPagerEx and it works, but there is an issue with the position number coming form the infinite view pager being a big number that needs to be converted to the correct position like you did in PageIndicator: |
This may help you, check it. Lines 40 to 42 in 8c2e9c7
|
This is the solutions indicated by @devflow in #42