-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gci error not clear #59
Comments
I've just added
Etc. It could really use a more readable error message, at first I thought the integration is just broken. |
I can also say rust is doing this very good for semicolon position. |
@georgettica The error reporting in gci is an area that could definitely improved. Until that happens I would recommend that you run gci in write mode to see what output gci expects. |
Renamings: * `RT` -> `Runtime` * `k6.NewMockVU` -> `k6test.NewVU` * `V` -> `ToGojaValue` * `TestBrowser.RT|V` -> `.runtime|toGojaValue` I split the `k6` package into `k6` and `k6test`. By the way, note that I needed to use `//nolint` in a couple of places because the gci linter has bugs that prevent me from passing the linter (see: daixiang0/gci#59).
Renamings: * `RT` -> `Runtime` * `k6.NewMockVU` -> `k6test.NewVU` * `V` -> `ToGojaValue` * `TestBrowser.RT|V` -> `.runtime|toGojaValue` I split the `k6` package into `k6` and `k6test`. By the way, note that I needed to use `//nolint` in a couple of places because the gci linter has bugs that prevent me from passing the linter (see: daixiang0/gci#59).
Renamings: * `RT` -> `Runtime` * `k6.NewMockVU` -> `k6test.NewVU` * `V` -> `ToGojaValue` * `TestBrowser.RT|V` -> `.runtime|toGojaValue` I split the `k6` package into `k6` and `k6test`. By the way, note that I needed to use `//nolint` in a couple of places because the gci linter has bugs that prevent me from passing the linter (see: daixiang0/gci#59).
You can try latest version :) |
I will do that soon and report back, thanks! |
the error
gci/pkg/analyzer/analyzer.go
Line 93 in 73cde23
jumped for me when I had
and the fix was to join the 3 github imports.
could we catch this error up somewhere so the error would be more along the lines "imports are not joined together, please remove newline in line X" ?
the error is
The text was updated successfully, but these errors were encountered: