Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer Etcd version #273

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

scholzj
Copy link
Contributor

@scholzj scholzj commented Feb 21, 2024

When running the ApiServerContainer with the default Etcd version 3.4.13 on Arm-based MacOS, it looks like the container registry doesn't serve the multi-arch manifest but serves only the container for amd64:

[2024-02-21 19:05:42,933] INFO Creating container for image: registry.k8s.io/etcd:3.4.13-0 (tc.registry.k8s.io/etcd:3.4.13-0:390)
[2024-02-21 19:05:43,088] INFO Container registry.k8s.io/etcd:3.4.13-0 is starting: 624c4a64007248aff8f451f551077d2189fd8f51197c48595be352c8fdac089b (tc.registry.k8s.io/etcd:3.4.13-0:454)
[2024-02-21 19:05:43,171] WARN The architecture 'amd64' for image 'registry.k8s.io/etcd:3.4.13-0' (ID sha256:05b738aa1bc6355db8a2ee8639f3631b908286e43f584a3d2ee0c472de033c28) does not match the Docker server architecture 'arm64'. This will cause the container to execute much more slowly due to emulation and may lead to timeout failures. (tc.registry.k8s.io/etcd:3.4.13-0:488)
[2024-02-21 19:05:43,172] INFO Container registry.k8s.io/etcd:3.4.13-0 started in PT0.238978S (tc.registry.k8s.io/etcd:3.4.13-0:544)

While that works, it seems suboptimal. This Pr updates the Etcd version used by default to 3.5.12. For this version, the multi-arch images seem to be served properly:

[2024-02-21 19:08:38,878] INFO Container registry.k8s.io/etcd:3.5.12-0 is starting: 0f6a5960a168baa4d983d16af245a357794939c5dec6861691f317f376dbb1fc (tc.registry.k8s.io/etcd:3.5.12-0:454)
[2024-02-21 19:08:38,970] INFO Container registry.k8s.io/etcd:3.5.12-0 started in PT0.244075S (tc.registry.k8s.io/etcd:3.5.12-0:544)

While I can override the Etcd version when starting the container, this seems like something what might be useful in general?

Signed-off-by: Jakub Scholz <[email protected]>
@scholzj scholzj requested a review from dajudge as a code owner February 21, 2024 18:10
@dajudge dajudge self-assigned this Feb 22, 2024
@dajudge dajudge added enhancement New feature or request type/dependency labels Feb 22, 2024
@dajudge
Copy link
Owner

dajudge commented Feb 22, 2024

Hey @scholzj, thanks for your contribution!

@dajudge dajudge merged commit 26b9eb7 into dajudge:master Feb 22, 2024
39 checks passed
@scholzj scholzj deleted the update-etcd-version branch February 22, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type/dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants