Skip to content

Commit

Permalink
Fix feature flag setting for ComponentTemplate APIs
Browse files Browse the repository at this point in the history
The feature flag was set for *most* of the builds, but there are a couple where it was missing.

Resolves elastic#53708
  • Loading branch information
dakrone committed Mar 18, 2020
1 parent ddedb94 commit 725517e
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 3 deletions.
8 changes: 8 additions & 0 deletions qa/smoke-test-multinode/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
* under the License.
*/

import org.elasticsearch.gradle.info.BuildParams

apply plugin: 'elasticsearch.testclusters'
apply plugin: 'elasticsearch.standalone-rest-test'
apply plugin: 'elasticsearch.rest-test'
Expand Down Expand Up @@ -46,3 +48,9 @@ integTest.runner {
].join(',')
}
}

testClusters.integTest {
if (BuildParams.isSnapshotBuild() == false) {
systemProperty 'es.itv2_feature_flag_registered', 'true'
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
---
"Basic CRUD":
- skip:
version: "all"
reason: "AwaitsFix https://github.com/elastic/elasticsearch/issues/53708"

- do:
cluster.put_component_template:
Expand Down
8 changes: 8 additions & 0 deletions x-pack/qa/core-rest-tests-with-security/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import org.elasticsearch.gradle.info.BuildParams

apply plugin: 'elasticsearch.testclusters'
apply plugin: 'elasticsearch.standalone-rest-test'
apply plugin: 'elasticsearch.rest-test'
Expand Down Expand Up @@ -37,3 +39,9 @@ testClusters.integTest {
user username: System.getProperty('tests.rest.cluster.username', 'test_user'),
password: System.getProperty('tests.rest.cluster.password', 'x-pack-test-password')
}

testClusters.integTest {
if (BuildParams.isSnapshotBuild() == false) {
systemProperty 'es.itv2_feature_flag_registered', 'true'
}
}

0 comments on commit 725517e

Please sign in to comment.