Fix: Disable Chained CAN Sending During OTA Updates #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lete Communication Control
|
Tested on Stark+Leaf production |
dalathegreat
approved these changes
Sep 28, 2024
done. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change disables certain CAN sending operations that are chained within the receiving methods during an OTA (Over-the-Air) update. Previously, only some sending operations were blocked, leading to incomplete coverage of CAN communication control during the update process.
Why
The prior implementation did not fully prevent CAN communication during OTA, particularly in cases where sending operations were triggered as part of receiving routines. This oversight allowed some chained communications to continue, potentially leading to incomplete or inconsistent behavior during OTA updates. This update corrects that behavior by ensuring these specific sending operations are disabled, thereby preventing any unintended communication during the OTA process.
How
Logic has been added to disable all CAN sending operations in the transmit_can method. The system now ensures that any sending chained to receiving actions is fully paused until the update process completes.