Fix panic issue and pause function terminology #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR addresses the confusion surrounding the "Pause" button functionality as reported in issue #494, titled "Pause button causes confusion."
This PR also fixes the issue reported "OTA updates causes RESET_PANIC above 7.1.1" reported om issue #492
Why
Users have expressed confusion regarding the purpose and impact of the "Pause" button, leading to questions about its functionality. By clarifying the terminology and providing additional context, we aim to improve user experience and reduce misunderstandings about the battery emulator's operations.
As for the fix, the why is obvious
How
Renamed the pause/resume buttons to "Pause charge/discharge" and "Resume charge/discharge" to provide clearer actions.
Updated the status label to "Power Status" to better reflect the current state of the system.
Highlighted information related to Maximum Charge and Maximum Discharge power to inform users about the effects of the pause/resume actions on battery performance.
For the fix it was added the ESP32Can.CANStop instruction to force stopping CAN Comminications. this was tested to solve the issue.