Tesla SX 2021+ batteries support #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalathegreat
approved these changes
Oct 21, 2024
matvey83
reviewed
Oct 21, 2024
matvey83
reviewed
Oct 22, 2024
Tesla Batteries: change explanation for experimental parameter
|
Is this OK to merge now? |
I see no reason to delay it. The dialogue was only about the wording of the comment and I took the proposed one as the final option. So we can merge it |
matvey83
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements experimental support for new 100 kW Tesla Model X and S batteries starting from the 2021 model year.
Why
These batteries use a different communication protocol with the BMS, requiring the transmission of additional CAN frames for proper battery operation.
How
This implementation introduces the transmission of additional CAN events with timing closely matching the original protocol.
By default, when the TESLA_MODEL_SX_BATTERY configuration is selected, the additional CAN frame transmission will be enabled.
Additionally, a new experimental define EXP_TESLA_BMS_DIGITAL_HVIL has been added, which triggers the transmission of these extra frames. This is necessary for testing with the latest BMS firmware for Model 3/Y batteries, as there is a hypothesis that the BMS firmware update, which communicates through the new 1CF and 118 frames, may also apply to these vehicles.