Feature: Add degradation data reset for 30kWH LEAF batteries #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this reset to 100%? |
|
Feature tested OK, successfully restored 2x 30kWh batteries into a state where more energy could be extracted from them (Faulty BMS firmware revision 4A) Merging! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements diagnostic commands used to reset degradation data, also known as SOH%
Why
Some 30kWh packs have a defective BMS firmware, that causes the degradation data to be incorrectly calculated, and SOH% drops too fast. Since we dont have any way to update the software on the battery yet, the next best solution is to reset the SOH% to factory new every once in a while.
How
There is a button added under the "More battery info" page, which can be pressed
The prompt asks the user if they are sure. If OK is pressed, we proceed with the SOH% reset