Change web based CAN log file format to CANdump #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only use values form CAN message if BMS is not in init state. - Quickly determine number of cell of the pack - Use broadcast battery_voltage and battery_SOC - Set default SOC to 0.05% to prevent battery empty event on startup
obbardc
suggested changes
Dec 3, 2024
obbardc
approved these changes
Dec 3, 2024
|
@obbardc is anything still blocking review approval? |
dalathegreat
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
LGTM! Now we just need to update the can-logging wiki page to explain the format
|
I will update the wiki later this morning.
Op di 3 dec. 2024 22:35 schreef Daniel Öster ***@***.***>:
… ***@***.**** approved this pull request.
LGTM! Now we just need to update the can-logging wiki page to explain the
format
—
Reply to this email directly, view it on GitHub
<#655 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFVJXN2JTKVBSJW5BHEHET2DYPYVAVCNFSM6AAAAABS5JPLH6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZWHAYDANZYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change web based CAN log format to CANdump format.
Improve performance by removing unnecessary strncat and strlens.
Why
Make logfiles directly compatible with SavvyCAN.
How
Slightly changed format.
Tested downloaded file with SavvyCAN