Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing battery and inverter options to GitHub workflows #669

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

lenvm
Copy link
Collaborator

@lenvm lenvm commented Dec 12, 2024

What

This PR adds missing battery and inverter options to GitHub workflows
It also sorts the options lexicographically, to be able to more easily compare the batteries and inverters listed in different files.

Why

To ensure that all different battery and inverter combinations get compiled automatically.

How

By updating the GitHub workflow files

@lenvm lenvm requested a review from dalathegreat December 12, 2024 21:34
Copy link
Owner

@dalathegreat dalathegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@lenvm lenvm merged commit 63b96f5 into dalathegreat:main Dec 12, 2024
44 checks passed
@lenvm lenvm deleted the feature/update-github-workflows branch December 20, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants