Skip Duplicate GitHub Actions #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-actions to all combinations workflow
lenvm
changed the title
dalathegreat
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the GitHub Workflow (a.k.a. GitHub Action) that is triggered to build all batteries.
Why
This change is introduced, because currently 88 checks are performed by GitHub Actions when an additional commit is pushed to an existing pull request, and many of these checks are duplicates. The duplicates arise as the workflows are triggered both by the
pushas well as by thepull_requesttrigger. Introducing this change, only 46 checks are performed, therefore significantly reducing the amount of builds done 🌍.Removing either the
pushorpull_requesttrigger was also considered, but does not lead to the desired behavior (see this discussion for reference How to trigger an action on push or pull request but not both? #26276).How
It does this by introducing the following GitHub Action in the workflow: Skip Duplicate Actions.