Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync SMA inverter protocols #710

Merged

Conversation

lenvm
Copy link
Collaborator

@lenvm lenvm commented Dec 29, 2024

What

This PR synchronises the SMA inverter protocols.

It also updates the name of the protocols:

  • BYD_SMAto SMA_BYD_HVS_CAN
  • SMA_CAN to SMA_BYD_H_CAN.

It also updates the files in terms of the order in which CAN messages are defined, allowing easier comparison of the different files.

Why

  • To take advantage of the developments done on the SMA TriPower Smart Energy (SMA-TRIPOWER-CAN) protocol, and introduce the updates in the other SMA protocols as well.
  • To ensure consistency in terms of naming used of the different protocols.
  • To allow easier comparison of the different SMA inverter files.

How

  • By comparing the different SMA inverter files (BYD_SMA, SMA-CAN, SMA-LV-CAN and SMA-TRIPOWER-CAN), line by line, and making the different files consistent to each other.

@lenvm lenvm requested a review from dalathegreat December 29, 2024 19:53
@dalathegreat
Copy link
Owner

Seems like good changes. Wiki will need some updating also after this is merged

@lenvm
Copy link
Collaborator Author

lenvm commented Dec 30, 2024

Perfect! Yes, let’s update the wiki after the PR is merged

@dalathegreat dalathegreat merged commit 2cf3ecd into dalathegreat:main Dec 30, 2024
47 checks passed
@dalathegreat
Copy link
Owner

All wiki pages have been updated. Noted that there are no inverters that actually use the SMA_BYD_H_CAN option, but I guess it is a nice to have feature incase we need it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants