Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardware to GitHub Actions workflows #715

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

lenvm
Copy link
Collaborator

@lenvm lenvm commented Dec 29, 2024

What

This PR implements automatic builds for the different supported hardware platforms, using GitHub Actions.

Why

It does this, to ensure that the code compiles for all different types of hardware. This prevents the need for bug fixes such as #714.

How

A GitHub Action workflow is added to compile the code for different hardware setups. This check is done on each push and each pull request.

@lenvm lenvm requested a review from dalathegreat December 29, 2024 22:36
@lenvm lenvm force-pushed the feature/add-hardware-to-github-actions branch from 2d2d5eb to eac36a7 Compare December 30, 2024 00:41
@dalathegreat
Copy link
Owner

@lenvm
Now that by default the LilyGo HW is not selected, we could make the compilation #error a bit easier to understand. I suggest changing the Battery-Emulator/Software/src/include.h

#error You must select a HW to run on!

into

#error You must select a target hardware in the USER_SETTINGS.h file!

@lenvm
Copy link
Collaborator Author

lenvm commented Dec 30, 2024

Good idea! Implemented in 58c15c5

@lenvm lenvm force-pushed the feature/add-hardware-to-github-actions branch from 58c15c5 to 6c8333f Compare December 30, 2024 17:21
@lenvm lenvm merged commit 52a5fd9 into dalathegreat:main Dec 30, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants