Feature: Add forced Tesla LFP balancing functionality #718
+210
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvgalen
reviewed
Jan 2, 2025
|
|
||
| // During forced balancing request via webserver, we allow the battery to exceed normal safety parameters | ||
| if (datalayer.battery.settings.user_requests_balancing) { | ||
| datalayer.battery.status.real_soc = 9900; //Force battery to show up as 99% when balancing |
There was a problem hiding this comment.
Why is the soc forced to 99%? As far as I can see, it is not used programmatically?
There was a problem hiding this comment.
Incase the battery shows 100%, charging would stop in the Safety.cpp file. So we need to ensure it does not.
Could also be solved with an if == 100, then 99 check
There was a problem hiding this comment.
Wouldn't it make more sense to have the safety check take the user_requests_balancing into account? And have safety then also look at he max charge power for instance? Only if the combination is satisfied may charging continue.
mvgalen
reviewed
Jan 2, 2025
| if (millis() - datalayer.battery.settings.balancing_start_time_ms >= datalayer.battery.settings.balancing_time_ms) { | ||
| datalayer.battery.settings.user_requests_balancing = false; | ||
| datalayer.battery.settings.balancing_start_time_ms = 0; // Reset the start time | ||
| //TODO, raise info event? Balancing time elapsed. Turning off... |
There was a problem hiding this comment.
perhaps a logging.println("TESLA: Balancing time finished"); ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements forced balancing functionality for Tesla LFP batteries (Model 3/Y)
Why
To help keep LFP batteries balanced outside of a Tesla vehicle. This mimics more how the batteries would be commanded in a vehicle.
How
The forced balancing mode can be enabled via the Webserver. It is recommended to run this once per month on Tesla LFP batteries. Before enabling, make sure battery is close to full, and you have enough sun or grid power to continue charging and forcing the balance!
When enabling the
Manual LFP balancing, the balancing runs for the specified amount of time, set inBalancing max time. The balancing parameters, Balancing float power , Max battery voltage , Max cell voltage and Max cell voltage deviation can also be adjusted from here.