Improvement: mqtt library replacement #768
Merged
+240
−1,222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No-Signal
force-pushed
the
feature/mqtt_library_replacement
branch
2 times, most recently
from
1f780e3 to
80f84f5
Compare
No-Signal
force-pushed
the
feature/mqtt_library_replacement
branch
from
80f84f5 to
aa7d34a
Compare
| NOTE: In some cases, the LilyGo must be powered through the main power connector instead of USB-C | ||
| when performing the initial firmware upload. | ||
| NOTE: On Mac, the following USB driver may need to be installed: https://github.com/WCHSoftGroup/ch34xser_macos | ||
|
|
||
| NOTE: If you see garbled messages on the serial console, change the serial console to match the baud rate to the code, currently 115200. | ||
|
|
||
| NOTE: If you see the error `Sketch too big` then check you set the Partition Scheme above correctly. | ||
|
|
||
| This video explains all the above mentioned steps: | ||
| <https://youtu.be/_mH2AjnAjDk> | ||
|
|
There was a problem hiding this comment.
Nice work! Could your remove the mention of lib dependency, essentially remove this row from README.md
- knolleary/pubsubclient MIT-License
dalathegreat
approved these changes
Jan 16, 2025
…mmand structure to make it easier to use
|
@No-Signal , can you update the comment on username/password in USER_SECRETS as described in issue #738 ? EDIT: No need, I fixed this in #802 |
…d confusion when setting a username and password
I have updated the template again as the new library allows setting a blank string for no authentication which should be easier for people to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of the unsupported MQTT library from Issue #761 using the ESP-MQTT library
This PR requires further testing & investigation into flash size before it can be considered ready
The initial MQTT connection always fails as the Wifi connection is not yet ready, need to implement a way to wait for Wifi to connect before starting the MQTT connection