-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beta BMW PHEV Support #804
Merged
Merged
+1,302
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements basic functionality Supported: -Pre/Post contactor voltage -Min/ Cell Temp -SOC
Add balancing status support (in advanced info )
Now enables balancing every 10secs
handle balancing status 2
Try i3 contactor close method, cleanup and more messages parsed
Include max capacity
fix mapping
Update branch from main
Adds a calculated cell delta voltage for monitoring via MQTT
Increased stale allowance Polling rate upped to 200ms Current reading added Various cleanups
Stale allowance can be tightened up after increased polling rate
valve state was referencing wrong lookup for description
cell temps given as temp + 50. Check value is not 0 (-50)
Support for battery wakeup. You MUST be using the native can bus for this to work for now.
SME sends a 255 sometimes
Update PHEV branch from main
Battery should now startup without any errors
Isolation test is called at startup - and results viewable in advanced
Introduce a slow update loop for slow changing values.
Very nice, I see you have a Wiki page going already for the PHEV. Shall we add the PHEV to the github build system already now, or later? |
Adds a test compilation for BMW_PHEV
dalathegreat
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
This was referenced Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements support for the Gen3/4 Hybrid batteries. You will need to use manual contactor control. It also sends the cell voltage delta over MQTT.
Working
Not Working
Untested
Why
Improving battery support in Battery Emulator
How
Implements a new battery type