Skip to content

Commit

Permalink
RuboCop appeasement (voxpupuli#404).
Browse files Browse the repository at this point in the history
  • Loading branch information
Ben Dalling committed Sep 27, 2017
1 parent 69659fb commit d82fdd9
Show file tree
Hide file tree
Showing 9 changed files with 201 additions and 216 deletions.
1 change: 1 addition & 0 deletions Vagrantfile
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# rubocop:disable Style/FileName
# TODO: Find out why cassandra::params not working with vagrant and CentOS 6.2
# TODO: Find out why cassandra::params not working with vagrant and CentOS 7.0
# TODO: Find out why cassandra::params not working with vagrant and Ubuntu 12.04.
Expand Down
77 changes: 35 additions & 42 deletions spec/unit/facter/cassandracmsheapnewsize_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,38 @@
allow(Facter::Util::Resolution).
to receive(:exec).with('nodetool version').
and_return('2.1.11.969')
expect(Facter.fact(:cassandrarelease).value).to eql('2.1.11')
expect(Facter.fact(:cassandramajorversion).value).to be(2)
expect(Facter.fact(:cassandraminorversion).value).to be(1)
expect(Facter.fact(:cassandrapatchversion).value).to be(11)
end

it { expect(Facter.fact(:cassandrarelease).value).to eql('2.1.11') }
it { expect(Facter.fact(:cassandramajorversion).value).to be(2) }
it { expect(Facter.fact(:cassandraminorversion).value).to be(1) }
it { expect(Facter.fact(:cassandrapatchversion).value).to be(11) }
end

describe 'cassandrarelease DDC' do
it do
allow(Facter::Util::Resolution).
to receive(:exec).with('nodetool version').
and_return('3.0.1')
expect(Facter.fact(:cassandrarelease).value).to eql('3.0.1')
expect(Facter.fact(:cassandramajorversion).value).to be(3)
expect(Facter.fact(:cassandraminorversion).value).to be(0)
expect(Facter.fact(:cassandrapatchversion).value).to be(1)
end

it { expect(Facter.fact(:cassandrarelease).value).to eql('3.0.1') }
it { expect(Facter.fact(:cassandramajorversion).value).to be(3) }
it { expect(Facter.fact(:cassandraminorversion).value).to be(0) }
it { expect(Facter.fact(:cassandrapatchversion).value).to be(1) }
end

describe 'Cassandra not installed or not running' do
it do
allow(Facter::Util::Resolution).
to receive(:exec).with('nodetool version').
and_return('')
expect(Facter.fact(:cassandrarelease).value).to be(nil)
expect(Facter.fact(:cassandramajorversion).value).to be(nil)
expect(Facter.fact(:cassandraminorversion).value).to be(nil)
expect(Facter.fact(:cassandrapatchversion).value).to be(nil)
end

it { expect(Facter.fact(:cassandrarelease).value).to be(nil) }
it { expect(Facter.fact(:cassandramajorversion).value).to be(nil) }
it { expect(Facter.fact(:cassandraminorversion).value).to be(nil) }
it { expect(Facter.fact(:cassandrapatchversion).value).to be(nil) }
end

describe 'Heap settings' do
Expand All @@ -48,12 +51,10 @@
Facter.fact(:processorcount).stubs(:value).returns('4')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to eq(512)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(512)
expect(Facter.fact(:cassandraheapnewsize).value).to be(128)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(128)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to eq(512) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(512) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(128) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(128) }
end

context 'm4.large' do
Expand All @@ -62,12 +63,10 @@
Facter.fact(:processorcount).stubs(:value).returns('2')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to be(2048)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(2048)
expect(Facter.fact(:cassandraheapnewsize).value).to be(200)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(200)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to be(2048) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(2048) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(200) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(200) }
end

context 'm4.xlarge' do
Expand All @@ -76,12 +75,10 @@
Facter.fact(:processorcount).stubs(:value).returns('2')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to be(4096)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(4096)
expect(Facter.fact(:cassandraheapnewsize).value).to be(200)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(200)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to be(4096) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(4096) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(200) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(200) }
end

context 'c4.2xlarge' do
Expand All @@ -90,12 +87,10 @@
Facter.fact(:processorcount).stubs(:value).returns('8')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to be(3840)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(3840)
expect(Facter.fact(:cassandraheapnewsize).value).to be(800)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(800)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to be(3840) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(3840) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(800) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(800) }
end

context 'i2.2xlarge' do
Expand All @@ -104,12 +99,10 @@
Facter.fact(:processorcount).stubs(:value).returns('8')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to be(8192)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(14_336)
expect(Facter.fact(:cassandraheapnewsize).value).to be(800)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(800)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to be(8192) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(14_336) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(800) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(800) }
end
end
end
77 changes: 35 additions & 42 deletions spec/unit/facter/cassandracmsmaxheapsize_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,38 @@
allow(Facter::Util::Resolution).
to receive(:exec).with('nodetool version').
and_return('2.1.11.969')
expect(Facter.fact(:cassandrarelease).value).to eql('2.1.11')
expect(Facter.fact(:cassandramajorversion).value).to be(2)
expect(Facter.fact(:cassandraminorversion).value).to be(1)
expect(Facter.fact(:cassandrapatchversion).value).to be(11)
end

it { expect(Facter.fact(:cassandrarelease).value).to eql('2.1.11') }
it { expect(Facter.fact(:cassandramajorversion).value).to be(2) }
it { expect(Facter.fact(:cassandraminorversion).value).to be(1) }
it { expect(Facter.fact(:cassandrapatchversion).value).to be(11) }
end

describe 'cassandrarelease DDC' do
it do
allow(Facter::Util::Resolution).
to receive(:exec).with('nodetool version').
and_return('3.0.1')
expect(Facter.fact(:cassandrarelease).value).to eql('3.0.1')
expect(Facter.fact(:cassandramajorversion).value).to be(3)
expect(Facter.fact(:cassandraminorversion).value).to be(0)
expect(Facter.fact(:cassandrapatchversion).value).to be(1)
end

it { expect(Facter.fact(:cassandrarelease).value).to eql('3.0.1') }
it { expect(Facter.fact(:cassandramajorversion).value).to be(3) }
it { expect(Facter.fact(:cassandraminorversion).value).to be(0) }
it { expect(Facter.fact(:cassandrapatchversion).value).to be(1) }
end

describe 'Cassandra not installed or not running' do
it do
allow(Facter::Util::Resolution).
to receive(:exec).with('nodetool version').
and_return('')
expect(Facter.fact(:cassandrarelease).value).to be(nil)
expect(Facter.fact(:cassandramajorversion).value).to be(nil)
expect(Facter.fact(:cassandraminorversion).value).to be(nil)
expect(Facter.fact(:cassandrapatchversion).value).to be(nil)
end

it { expect(Facter.fact(:cassandrarelease).value).to be(nil) }
it { expect(Facter.fact(:cassandramajorversion).value).to be(nil) }
it { expect(Facter.fact(:cassandraminorversion).value).to be(nil) }
it { expect(Facter.fact(:cassandrapatchversion).value).to be(nil) }
end

describe 'Heap settings' do
Expand All @@ -48,12 +51,10 @@
Facter.fact(:processorcount).stubs(:value).returns('4')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to eq(512)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(512)
expect(Facter.fact(:cassandraheapnewsize).value).to be(128)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(128)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to eq(512) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(512) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(128) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(128) }
end

context 'm4.large' do
Expand All @@ -62,12 +63,10 @@
Facter.fact(:processorcount).stubs(:value).returns('2')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to be(2048)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(2048)
expect(Facter.fact(:cassandraheapnewsize).value).to be(200)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(200)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to be(2048) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(2048) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(200) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(200) }
end

context 'm4.xlarge' do
Expand All @@ -76,12 +75,10 @@
Facter.fact(:processorcount).stubs(:value).returns('2')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to be(4096)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(4096)
expect(Facter.fact(:cassandraheapnewsize).value).to be(200)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(200)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to be(4096) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(4096) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(200) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(200) }
end

context 'c4.2xlarge' do
Expand All @@ -90,12 +87,10 @@
Facter.fact(:processorcount).stubs(:value).returns('8')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to be(3840)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(3840)
expect(Facter.fact(:cassandraheapnewsize).value).to be(800)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(800)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to be(3840) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(3840) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(800) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(800) }
end

context 'i2.2xlarge' do
Expand All @@ -104,12 +99,10 @@
Facter.fact(:processorcount).stubs(:value).returns('8')
end

it do
expect(Facter.fact(:cassandramaxheapsize).value).to be(8192)
expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(14_336)
expect(Facter.fact(:cassandraheapnewsize).value).to be(800)
expect(Facter.fact(:cassandracmsheapnewsize).value).to be(800)
end
it { expect(Facter.fact(:cassandramaxheapsize).value).to be(8192) }
it { expect(Facter.fact(:cassandracmsmaxheapsize).value).to be(14_336) }
it { expect(Facter.fact(:cassandraheapnewsize).value).to be(800) }
it { expect(Facter.fact(:cassandracmsheapnewsize).value).to be(800) }
end
end
end
Loading

0 comments on commit d82fdd9

Please sign in to comment.